Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when determining if it is safe to repair a cluster #2494

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Fix NPE when determining if it is safe to repair a cluster #2494

merged 1 commit into from
Nov 22, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 22, 2022

What this PR does / why we need it:

This PR fixes an NPE when determining if it is safe to repair a cluster. We wrongly assumed that we'll always be able to determine the kubelet version when running the SafeToRepair function. With this, we'll skip a node if we can't determine its kubelet version instead of throwing an NPE.

This is similar to #2483 but in a different place.

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix a panic (NPE) when determining if it is safe to repair a cluster when there's no kubelet or kubelet systemd unit on the node

Documentation:

NONE

@xmudrii
Fix NPE when determining if it is safe to repair a cluster
6f048ec 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii added the backport-needed Denotes a PR or issue that has not been fully backported. label Nov 22, 2022
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 22, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 22, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 258248620aeace7b958ca82223a281df9d570ba2

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 22, 2022

/cherrypick release/v1.5

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.5 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Nov 22, 2022

/cherrypick release/v1.4

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.4 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 725363b into main Nov 22, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Nov 22, 2022
@kubermatic-bot kubermatic-bot deleted the fix-repair-npe branch November 22, 2022 13:21
@kubermatic-bot kubermatic-bot mentioned this pull request Nov 22, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2495

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Nov 22, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2496

In response to this:

/cherrypick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kron4eg @kubermatic-bot @ahmedwaleedmalik