-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ca-bundle configuration for machine controller webhook #2586
Fix ca-bundle configuration for machine controller webhook #2586
Conversation
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik please also add
to |
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 9a3705a854f3d9f34d376202aa1a3ea737a9c702
|
/cherry-pick release/v1.5 |
@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ahmedwaleedmalik: new pull request created: #2587 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release/v1.5 |
I meant v1.4. |
@xmudrii: new pull request could not be created: failed to create pull request against kubermatic/kubeone#release/v1.5 from head kubermatic-bot:cherry-pick-2586-to-release/v1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubermatic:release/v1.5 and kubermatic-bot:cherry-pick-2586-to-release/v1.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xmudrii: new pull request created: #2589 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com
What this PR does / why we need it:
Adds missing flag, volume and volume mount for custom CA bundle is machine-controller webhook's manifests.
Which issue(s) this PR fixes:
Fixes #2585
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: