Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ca-bundle configuration for machine controller webhook #2586

Merged
merged 2 commits into from
Jan 11, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What this PR does / why we need it:
Adds missing flag, volume and volume mount for custom CA bundle is machine-controller webhook's manifests.

Which issue(s) this PR fixes:

Fixes #2585

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fixes an issue where custom ca-bundle was not being propagated to the machine controller webhooks

Documentation:

NONE

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik added the backport-needed Denotes a PR or issue that has not been fully backported. label Jan 11, 2023
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 11, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2023
@kron4eg
Copy link
Member

kron4eg commented Jan 11, 2023

@ahmedwaleedmalik please also add

"kubeone.k8c.io/cabundle-hash": "{{ .Config.CABundle | sha256sum }}"

to spec.template.metadata.annotations

Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@kron4eg
Copy link
Member

kron4eg commented Jan 11, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a3705a854f3d9f34d376202aa1a3ea737a9c702

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@ahmedwaleedmalik
Copy link
Member Author

/cherry-pick release/v1.5

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #2587

In response to this:

/cherry-pick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Jan 16, 2023

/cherrypick release/v1.5

@xmudrii
Copy link
Member

xmudrii commented Jan 16, 2023

I meant v1.4.
/cherry-pick release/v1.4

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request could not be created: failed to create pull request against kubermatic/kubeone#release/v1.5 from head kubermatic-bot:cherry-pick-2586-to-release/v1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubermatic:release/v1.5 and kubermatic-bot:cherry-pick-2586-to-release/v1.5"}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2589

In response to this:

I meant v1.4.
/cherry-pick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing caBundle Volume Mount for Machine Controller WebHook
4 participants