Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.5] Actually bind cri-tools version for Ubuntu, CentOS, and Amazon Linux #2627

Merged
merged 3 commits into from
Jan 27, 2023
Merged

[release/v1.5] Actually bind cri-tools version for Ubuntu, CentOS, and Amazon Linux #2627

merged 3 commits into from
Jan 27, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 27, 2023

What this PR does / why we need it:

Manual backport of #2626 to the release/v1.5 branch.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@xmudrii
Actually bind cri-tools version for Ubuntu, CentOS, and Amazon Linux
f6670ad 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update fixtures
39a6c2d 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update v1.5.6 release date
b6b3e34 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fafcd054d7fed202dbc6c518aebb7bac42773c5a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@kubermatic-bot kubermatic-bot merged commit 3569071 into release/v1.5 Jan 27, 2023
@kubermatic-bot kubermatic-bot deleted the cri-bind branch January 27, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik