Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.4] Updates to kubernetes-cni, cri-tools, and supported Kubernetes versions #2628

Closed
wants to merge 6 commits into from

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 27, 2023

What this PR does / why we need it:

The latest (January 2023) Kubernetes patch releases introduced some changes to packages that are described in #2607.

We were able to easily mitigate issues on main and release/v1.5 because those branches/versions are using containerd 1.6.

However, we cannot do that easily for release/v1.4 because it's using containerd 1.5 and cri-tools v1.26.0 doesn't support containerd 1.5. Updating containerd to 1.6 at this point would be too complicated because we have to update it in machine-controller, OSM, and KubeOne itself.

The idea for this PR is:

  • We forbid using 1.23.16 and newer with KubeOne 1.4
    • We will revisit this if the issue gets solved on the Kubernetes side
  • We strongly recommend upgrading to KubeOne 1.5 as soon as possible
  • We'll upgrade kubernetes-cni to v1.2.0 because it's an easy win
  • We'll upgrade and enforce cri-tools to v1.25.0
    • On CentOS and Amazon Linux 2, KubeOne will automatically downgrade cri-tools to v1.25.0 if newer is present
    • On Ubuntu, downgrading is possible with the --force flag

What type of PR is this?
/kind bug
/kind api-change

Does this PR introduce a user-facing change? Then add your Release Note here:

Update kubernetes-cni to v1.2.0 and cri-tools to v1.25.0 to solve the issue with `crictl` not being able to interact with containerd. Set the maximum Kubernetes version to v1.23.15 because v1.23.16+ is requiring cri-tools v1.26.0 which doesn't work with containerd 1.5

Documentation:

TBD

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 27, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 26ebec9df60a23596cbb5c392fa5c907f7c34cba

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Feb 20, 2023

We'll tackle this in another PR.

@xmudrii xmudrii closed this Feb 20, 2023
@xmudrii xmudrii deleted the cri-bind-1.4 branch February 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants