Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure machine-controller during install and upgrade #304

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Ensure machine-controller during install and upgrade #304

merged 2 commits into from
Mar 22, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Mar 22, 2019

Fixes #236

machine-controller will be kept updated

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 22, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f31c02701075e5600e4ab753daf2b3102c9e78b3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Mar 22, 2019

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Mar 22, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Mar 22, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019
@kron4eg kron4eg requested a review from xmudrii March 22, 2019 10:42
@kron4eg
Copy link
Member Author

kron4eg commented Mar 22, 2019

/retest

@kron4eg
Ensure machine-controller during install and upgrade
879d210 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Mar 22, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Mar 22, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Mar 22, 2019

/test pull-kubeone-e2e-upgrade-digitalocean

@kron4eg kron4eg changed the title Ensure machine-controller during install and upgrade [WIP] Ensure machine-controller during install and upgrade Mar 22, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2019
@kron4eg
update MachineDeployment retry logic
290973e 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg changed the title [WIP] Ensure machine-controller during install and upgrade Ensure machine-controller during install and upgrade Mar 22, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2019
@xmudrii
Copy link
Member

xmudrii commented Mar 22, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fa30cc97ca77883c7a986bda8b0e3e3ae27ab5b1

@kubermatic-bot kubermatic-bot merged commit e413b34 into master Mar 22, 2019
@kubermatic-bot kubermatic-bot deleted the 236-mc-upgrades branch March 22, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @xmudrii @kubermatic-bot