fix: Deploy User defined addons before external CCM initialization

[kron4eg]

What this PR does / why we need it:
This is fix for situation when we have both cloud provider and CNI set to external.

apiVersion: kubeone.k8c.io/v1beta2
kind: KubeOneCluster

versions:
  kubernetes: v1.28.7

cloudProvider:
  external: true

clusterNetwork:
  cni:
    external: {}

addons:
  enable: true
  addons:
  - name: calico-vxlan

This results to endless waiting for control-plane nodes to be initialized. It happens because Nodes are not ready (for the lack of CNI).

Which issue(s) this PR fixes:

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Deploy user defined addons before the external CCM initialization. This fixes an issue with cluster provisioning for users that use both external CCM and external CNI

Documentation:

NONE

[kubermatic-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[kron4eg]

/test pull-kubeone-e2e-aws-default-calico-containerd-external-v1.27.7

[kron4eg]

/cherrypick release/v1.6

[kron4eg]

/cherrypick release/v1.7

[kubermatic-bot]

@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/approve

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kron4eg]

/test pull-kubeone-e2e-aws-default-calico-containerd-external-v1.27.7

[kubermatic-triage-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[kron4eg]

/lgtm cancel

[kron4eg]

Looks like calico-vxlan is broken in general

[kron4eg]

even when I run the cluster with CNI created directly from

kubectl apply -f https://raw.githubusercontent.com/projectcalico/calico/v3.27.2/manifests/calico-vxlan.yaml

it's still failing

[kron4eg]

/cc @xrstf

Please mark this failing test as ignored as it's not entirely relevant.

[xrstf]

/override pull-kubeone-e2e-aws-default-calico-containerd-external-v1.27.7

[kubermatic-bot]

@xrstf: Overrode contexts on behalf of xrstf: pull-kubeone-e2e-aws-default-calico-containerd-external-v1.27.7

In response to this:

/override pull-kubeone-e2e-aws-default-calico-containerd-external-v1.27.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/lgtm

🚀

[kubermatic-bot]

LGTM label has been added.

Git tree hash: c431b71162c45664159131fce23c8f4ec31ae637

[kubermatic-bot]

@kron4eg: #3065 failed to apply on top of branch "release/v1.6":

Applying: Deploy User defined addons before external CCM initialization
Using index info to reconstruct a base tree...
M	pkg/tasks/tasks.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/tasks/tasks.go
CONFLICT (content): Merge conflict in pkg/tasks/tasks.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Deploy User defined addons before external CCM initialization
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@kron4eg: new pull request created: #3068

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xmudrii]

/release-note-edit

Deploy user defined addons before the external CCM initialization. This fixes an issue for users that use both external CCM and external CNI

[xmudrii]

/release-note-edit

Deploy user defined addons before the external CCM initialization. This fixes an issue with cluster provisioning for users that use both external CCM and external CNI