Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean yum caches when configuring repos #3146

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Clean yum caches when configuring repos #3146

merged 2 commits into from
Apr 16, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 16, 2024

What this PR does / why we need it:

We must clean yum cache upon changing the package repository because older yum versions (e.g. CentOS and Amazon Linux 2) don't detect the change otherwise.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Clean `yum` cache upon configuring Kubernetes repos. This fixes an issue with cluster upgrades failing on nodes with an older `yum` version

Documentation:

NONE

/assign @kron4eg

@xmudrii
Clean yum caches when configuring repos
555c40c 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Update fixtures
9b9da33 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. labels Apr 16, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@xmudrii xmudrii added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Apr 16, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Apr 16, 2024
@xmudrii xmudrii added this to the KubeOne 1.8 milestone Apr 16, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Apr 16, 2024

/test pull-kubeone-e2e-aws-centos-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7

@xmudrii xmudrii added the backport-needed Denotes a PR or issue that has not been fully backported. label Apr 16, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Apr 16, 2024

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Apr 16, 2024

/cherrypick release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member

kron4eg commented Apr 16, 2024

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5e23f67803a0c1ea426686e1f805aed3d9f4c31f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2024
@xmudrii xmudrii marked this pull request as ready for review April 16, 2024 13:44
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Apr 16, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit c7014ab into main Apr 16, 2024
14 checks passed
@kubermatic-bot kubermatic-bot deleted the fix-upgrades branch April 16, 2024 14:56
@kubermatic-bot kubermatic-bot mentioned this pull request Apr 16, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3147

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3148

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-needed Denotes a PR or issue that has not been fully backported. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg