Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Azure terraform example to Standard SKU for IP addresses #3149

Merged
merged 5 commits into from
Apr 17, 2024
Merged

Move Azure terraform example to Standard SKU for IP addresses #3149

merged 5 commits into from
Apr 17, 2024

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 16, 2024 •
edited
Loading

What this PR does / why we need it:
This fixes broken LoadBalancer functionality in azure CCM (it refuses to add Basic IPs into the LB)

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind regression

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] The example Terraform configs for Azure have been migrated to use the Standard SKU for IP addresses. This is a breaking change for existing setups; in which case you should continue using your current SKU. Manual migration is possible by dissociating IP from the VM and LB, the migrating it, and assigning it back, however please consider all potential risks before doing this migration

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 16, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2024
@kron4eg
Move to Standard IPs
74ee24d 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kron4eg
Accociate NSG to Subnet
088cfe0 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kron4eg
allow kubeAPI
3a3487c 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Apr 16, 2024
@kron4eg kron4eg changed the title Move to Standard IPs Move Azure terraform example to Standard SKU for IP addresses Apr 16, 2024
@kron4eg
Copy link
Member Author

kron4eg commented Apr 16, 2024

/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7

@kron4eg
Copy link
Member Author

kron4eg commented Apr 16, 2024

/test pull-kubeone-e2e-azure-default-install-containerd-external-v1.27.11

@kron4eg
Add missing terraform -> MachineDeployment PublicIPSKU field transfer
fc17595 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kron4eg
Copy link
Member Author

kron4eg commented Apr 17, 2024

/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7

@kron4eg
Copy link
Member Author

kron4eg commented Apr 17, 2024

/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7
/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.28.7-to-v1.29.2
/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-from-v1.27.11-to-v1.28.7

@kubermatic-bot
Copy link
Contributor

@kron4eg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubeone-e2e-azure-default-install-containerd-external-v1.27.11 3c8e5c2 link true /test pull-kubeone-e2e-azure-default-install-containerd-external-v1.27.11
pull-kubeone-e2e-azure-default-stable-upgrade-containerd-from-v1.27.11-to-v1.28.7 5ea88e8 link true /test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-from-v1.27.11-to-v1.28.7
pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7 5ea88e8 link true /test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.27.11-to-v1.28.7
pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.28.7-to-v1.29.2 5ea88e8 link true /test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.28.7-to-v1.29.2

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 17, 2024

/test pull-kubeone-e2e-azure-default-stable-upgrade-containerd-external-from-v1.28.7-to-v1.29.2

@kron4eg
Use actual LB in Azure e2e
15f4e71 
Signed-off-by: Artiom Diomin <artiom@kubermatic.com>
@kron4eg kron4eg marked this pull request as ready for review April 17, 2024 16:52
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024
@kron4eg kron4eg requested a review from xmudrii April 17, 2024 16:55
@kron4eg
Copy link
Member Author

kron4eg commented Apr 17, 2024

/cc @xmudrii

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 17, 2024
xmudrii
xmudrii reviewed Apr 17, 2024
View reviewed changes
examples/terraform/azure/variables.tf
Comment on lines -109 to -112
variable "ip_sku" {
default = "Basic"
description = "SKU to use for IP addresses"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave this variable but default it to Standard so users with existing setups can eventually migrate to the new Terraform configs if they want.

xmudrii
xmudrii reviewed Apr 17, 2024
View reviewed changes
examples/terraform/azure/main.tf
resource "azurerm_public_ip" "lbip" {
count = local.loadbalancer_count

name = "${var.cluster_name}-lbip"
location = var.location
resource_group_name = azurerm_resource_group.rg.name
allocation_method = "Dynamic"
sku = var.ip_sku
allocation_method = "Static"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a variable for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is, it doesn't work with Basic anymore. So does it make sense to parametrize it?

@xmudrii xmudrii added the code-freeze-approved Indicates a PR has been approved by release managers during code freeze. label Apr 17, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. label Apr 17, 2024
@xmudrii xmudrii added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. labels Apr 17, 2024
@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Apr 17, 2024
@xmudrii xmudrii added kind/regression Categorizes issue or PR as related to a regression from a prior release. and removed do-not-merge/code-freeze Indicates that a PR should not merge because it has not been approved for code freeze yet. labels Apr 17, 2024
@xmudrii xmudrii added this to the KubeOne 1.8 milestone Apr 17, 2024
xmudrii
xmudrii approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f794a2986dcebcf24696e63cde158250fbb93eb0

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@kubermatic-bot kubermatic-bot merged commit 01c6f88 into kubermatic:main Apr 17, 2024
13 checks passed
@kron4eg kron4eg deleted the azure-standard-sku branch April 17, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. code-freeze-approved Indicates a PR has been approved by release managers during code freeze. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii