Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout after kubelet binary and kubeadm upgrade #319

Merged
merged 3 commits into from
Mar 29, 2019
Merged

Add timeout after kubelet binary and kubeadm upgrade #319

merged 3 commits into from
Mar 29, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 28, 2019

What this PR does / why we need it:

This PR adds a timeout:

  • 1 minute after upgrading the kubelet binary
  • 15 seconds after running kubeadm upgrade

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #269

Release note:

NONE

/assign @kron4eg

@xmudrii
Add timeout after kubelet binary and kubeadm upgrade
e8851fe 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg March 28, 2019 13:18
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2019
kron4eg
kron4eg approved these changes Mar 28, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c79c623b77d63853ec5975b4bec972314863b67b

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/retest

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 28, 2019
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 28, 2019
@xmudrii xmudrii force-pushed the upgrades/increase-timeout branch 3 times, most recently from d0597f6 to 30bd90a Compare March 28, 2019 14:22
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

@xmudrii
Add additional checks to E2E tests
c264a20 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Mar 28, 2019
@xmudrii
Increase upgrade tests timeout to 60m
17b8911 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 28, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Mar 28, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/retest

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 17b8911 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kron4eg
kron4eg approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c43a26e164243ed54ba7aa20fa2ce0b26d1cec66

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 5206a8c into master Mar 29, 2019
@kubermatic-bot kubermatic-bot deleted the upgrades/increase-timeout branch March 29, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg