Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2 minutes delay after installing before upgrade in E2E #320

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 29, 2019

What this PR does / why we need it:

This PR adds a two minutes delay in E2E tests after installing and creating nodes to let nodes settle down for some time. This may resolve E2E flakes we have.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #269

Release note:

NONE

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg March 29, 2019 12:27
@kubermatic-bot kubermatic-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 29, 2019
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2019
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4c17513a6c353e0bb0fecfee5c711ffccd9a51f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-digitalocean-conformance-1.13.5

@xmudrii
Copy link
Member Author

xmudrii commented Mar 29, 2019

/test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.0
/test pull-kubeone-e2e-aws-conformance-1.14.0

@kubermatic-bot kubermatic-bot merged commit cfac141 into master Mar 29, 2019
@kubermatic-bot kubermatic-bot deleted the upgrades/delay branch March 29, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants