-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the upgrade process to stop using config on upgrade #3251
Conversation
Skipping CI for Draft Pull Request. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all, I like the idea.
6a2cf7e
to
4bff91e
Compare
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
4bff91e
to
bd3f327
Compare
/cherrypick release/v1.8 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 20d9d6a9ae373f0a41cf2dc083f1f5ee8ec94eda
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xmudrii: new pull request created: #3253 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR refactors the cluster upgrade process to adhere to recommendations from the upstream community. With that, using the
--config
flag along with thekubeadm upgrade apply
command:kubeadm
writes configuration to different ConfigMaps in thekube-system
namespace, mainlykubeadm-config
,kubelet-config
, andkube-proxy
. The recommended workflow is to update the needed ConfigMap and then run the appropriatekubeadm
command as described in the document.Upon initiating the upgrade process, KubeOne will build the Kubernetes clientset, generate new Kubeadm configs and update all the ConfigMaps used by Kubeadm. Kubeadm will reconfigure the cluster as needed based on what's changed (if anything is changed at all).
This however means that some options are now immutable, but most of them should not be user-facing, and I don't think we ever supported changing these options:
InitConfiguration
andJoinConfiguration
structs. There is.LocalAPIEndpoint.AdvertiseAddress
, but I don't think we support changing the IP address of existing control plane or worker nodesWhich issue(s) this PR fixes:
xref #3205
What type of PR is this?
/kind feature
/kind design
Special notes for your reviewer:
In the future, we should refactor the force upgrade process to work in a reconciliation manner, i.e. to avoid running the full upgrade process, but only compare what's changed and regenerate only those affected manifests.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: