-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Retryable tasks #328
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 17b5d7daa4d3d7dc131e6444bdf46269cb22d968
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
/retest |
1 similar comment
/retest |
The cluster never got provisioned. |
/retest |
1 similar comment
/retest |
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@xmudrii: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This is a known flake and we had it for a long time now. For some reason API seems to be slower than usual and it takes more time to replace the worker nodes than expected. If you check nodes in the cluster, you'll see that they're getting replaced, but tests timeout by the time the third node should be replaced. Because this is not a release blocking flake and that all other tests have many green runs, I'm going to skip this test. |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR implements retryable tasks. Some tasks are ran only once while some are ran 3 times. This package is based on the
k8s.io/apimachinery/util/wait
package and theExponentialBackoff
function.This is required for proper upgrades support from 1.13 to 1.14 and to stabilize the CI.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref #269
Release note:
/assign @kron4eg