Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Retryable tasks #328

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Implement Retryable tasks #328

merged 1 commit into from
Apr 2, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 2, 2019

What this PR does / why we need it:

This PR implements retryable tasks. Some tasks are ran only once while some are ran 3 times. This package is based on the k8s.io/apimachinery/util/wait package and the ExponentialBackoff function.

This is required for proper upgrades support from 1.13 to 1.14 and to stabilize the CI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #269

Release note:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg April 2, 2019 10:35
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2019
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 17b5d7daa4d3d7dc131e6444bdf46269cb22d968

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0
This is related to E2E tests and not to the upgrade logic itself. I'll create a PR to fix this.

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

The cluster never got provisioned.
/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

/retest

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 b848f23 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Apr 2, 2019

This is a known flake and we had it for a long time now. For some reason API seems to be slower than usual and it takes more time to replace the worker nodes than expected. If you check nodes in the cluster, you'll see that they're getting replaced, but tests timeout by the time the third node should be replaced.

Because this is not a release blocking flake and that all other tests have many green runs, I'm going to skip this test.
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

In response to this:

This is a known flake and we had it for a long time now. For some reason API seems to be slower than usual and it takes more time to replace the worker nodes nodes than expected. If you check nodes in the cluster, you'll see that they're getting replaced, but tests timeout by the time the third node should be replaced.

Because this is not a release blocking flake and that tests all other tests have many green runs, I'm going to skip this test.
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 40c0b4c into master Apr 2, 2019
@kubermatic-bot kubermatic-bot deleted the retry branch April 2, 2019 22:25
@xmudrii xmudrii mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants