Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.8] Allow upstream cluster autoscaler flags configuration #3306

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions addons/cluster-autoscaler/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,20 @@ You need to replace the following values with the actual ones:

* `CLUSTER_AUTOSCALER_IMAGE` can be used to replace the Cluster Autoscaler image
* The minor versions of Cluster Autoscaler and Kubernetes cluster should
match, as per
[Cluster Autoscaler recommendations][recommended-autoscaler-versions]
match, as per [Cluster Autoscaler recommendations][recommended-autoscaler-versions].
* You can find the available Cluster Autoscaler versions by searching for
Cluster Autoscaler in the
[autoscaler GitHub repository][autoscaler-releases]
Cluster Autoscaler in the [autoscaler GitHub repository][autoscaler-releases].
* `CLUSTER_AUTOSCALER_SKIP_LOCAL_STORAGE` can be used to define the value of `--skip-nodes-with-local-storage=`.
* Possible values are `"true"`or `"false"`
* Default is `"true"`, as described in the [FAQ][autoscaler-faq].
* `CLUSTER_AUTOSCALER_ENFORCE_NODE_GROUP_MIN_SIZE` can be used to define the value of `--enforce-node-group-min-size=`.
* Possible values are `"true"` or `"false"`.
* Default is `"false"`, as described in the [FAQ][autoscaler-faq].
* Set the value to `"true"`, if you are facing issue similare to the one described over [here][enforce-node-group-min-size] in the [FAQ][autoscaler-faq].
* `CLUSTER_AUTOSCALER_BALANCE_SIMILAR_NODE_GROUP` can be used to define the value of `--balance-similar-node-groups=`.
* Possible values are `"true"` or `"false"`.
* Default is `"false"`, as described in the [FAQ][autoscaler-faq].
* Set the value to `"true"`, if you are facing issue similare to the one described over [here][balance-similar-node-groups] in the [FAQ][autoscaler-faq].

You can find more information about deploying addons in the
[Addons document][using-addons].
Expand All @@ -138,3 +144,5 @@ You can find more information about deploying addons in the
[autoscaler-releases]: https://github.com/kubernetes/autoscaler/releases
[using-addons]: https://docs.kubermatic.com/kubeone/v1.8/guides/addons/
[autoscaler-faq]: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md
[enforce-node-group-min-size]: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#my-cluster-is-below-minimum--above-maximum-number-of-nodes-but-ca-did-not-fix-that-why
[balance-similar-node-groups]: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/FAQ.md#im-running-cluster-with-nodes-in-multiple-zones-for-ha-purposes-is-that-supported-by-cluster-autoscaler
2 changes: 2 additions & 0 deletions addons/cluster-autoscaler/cluster-autoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,8 @@ spec:
- --namespace=kube-system
- --skip-nodes-with-local-storage={{ default "true" .Params.CLUSTER_AUTOSCALER_SKIP_LOCAL_STORAGE }}
- --node-group-auto-discovery=clusterapi:namespace=kube-system
- --enforce-node-group-min-size={{ default "false" .Params.CLUSTER_AUTOSCALER_ENFORCE_NODE_GROUP_MIN_SIZE }}
- --balance-similar-node-groups={{ default "false" .Params.CLUSTER_AUTOSCALER_BALANCE_SIMILAR_NODE_GROUP }}
- --logtostderr=true
- --stderrthreshold=info
- --v=4
Expand Down