Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics server #338

Merged
merged 3 commits into from
Apr 10, 2019
Merged

metrics server #338

merged 3 commits into from
Apr 10, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 4, 2019

Fixes #314

metrics-server is deployed by default with possibility to opt out

@kron4eg kron4eg requested a review from xmudrii April 4, 2019 22:31
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 4, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 5, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kron4eg
Copy link
Member Author

kron4eg commented Apr 5, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 5, 2019

/override pull-kubeone-e2e-hetzner-conformance-1.13.5
/override pull-kubeone-e2e-hetzner-conformance-1.14.0
/override pull-kubeone-e2e-hetzner-upgrade-1.13.5-1.14.0

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-hetzner-conformance-1.13.5, pull-kubeone-e2e-hetzner-conformance-1.14.0, pull-kubeone-e2e-hetzner-upgrade-1.13.5-1.14.0

In response to this:

/override pull-kubeone-e2e-hetzner-conformance-1.13.5
/override pull-kubeone-e2e-hetzner-conformance-1.14.0
/override pull-kubeone-e2e-hetzner-upgrade-1.13.5-1.14.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 5, 2019

/retest pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

@kron4eg
Copy link
Member Author

kron4eg commented Apr 5, 2019

/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0

xmudrii
xmudrii reviewed Apr 8, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit otherwise lgtm

examples/terraform/digitalocean/output.tf Outdated
droplet_size = "${var.droplet_size}"
region = "${var.region}"
sshPublicKeys = ["${digitalocean_ssh_key.deployer.public_key}"]
replicas = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency across all provider this should be 3

@kron4eg
Copy link
Member Author

kron4eg commented Apr 8, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 8, 2019

As per DigitalOcean status page, there are API issues which are causing flakes. I'll retry testing once the issue is resolved.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 8, 2019

/test pull-kubeone-e2e-aws-conformance-1.14.0

@kron4eg
Copy link
Member Author

kron4eg commented Apr 9, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67347e367e79d1f02b181e103b676d2836beb5f1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Apr 9, 2019

/retest

2 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented Apr 9, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Apr 9, 2019

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

@kron4eg Needs rebase

@kron4eg
metrics-server manifests
fe4ddf1 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Create metrics-server objects
47e93fc 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Deploy metrics-server
7a2a311 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@xmudrii
Copy link
Member

xmudrii commented Apr 9, 2019

/retest

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 9, 2019 •
edited
Loading

@kron4eg: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-hetzner-upgrade-1.13.5-1.14.0 0a55541 link /test pull-kubeone-e2e-hetzner-upgrade-1.13.5-1.14.0
pull-kubeone-e2e-hetzner-conformance-1.13.5 0a55541 link /test pull-kubeone-e2e-hetzner-conformance-1.13.5
pull-kubeone-e2e-hetzner-conformance-1.14.0 0a55541 link /test pull-kubeone-e2e-hetzner-conformance-1.14.0
pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1 7a2a311 link /test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 9, 2019

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Apr 10, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dca00e8d49b7821ed9360c710a24e1c548a3575a

@kubermatic-bot kubermatic-bot merged commit 9e8a7e8 into master Apr 10, 2019
@kubermatic-bot kubermatic-bot deleted the 314-metrics-server branch April 10, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii