Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the KubeOne Cluster API proposal #343

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add the KubeOne Cluster API proposal #343

merged 1 commit into from
Apr 11, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 9, 2019 •
edited
Loading

What this PR does / why we need it:

This PR adds the proposal for refactoring the KubeOne API.

Goals:

  • Build the KubeOne Cluster API to replace the API we're currently using.
  • Ensure the new API follows the Kubernetes API conventions.
  • Implement the versioning support for the new KubeOne API.
  • Follow the recommendations for creating the Cluster APIs from the Cluster-API project.

Non-goals:

  • Adopt the upstream Cluster-API.
    • Since the Cluster-API project is in the alpha phase and that some features we need may be missing, initially we'll build a downstream API for KubeOne while following the recommendations from the upstream API.
  • Store the manifest used to provision the cluster on the target cluster in form of a Secret or a CustomResource.
  • Provide a mechanism for automatic migration from the old KubeOne API to the new API.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #259

Release note:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg April 9, 2019 12:37
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2019
@xmudrii
Add the KubeOne Cluster API proposal
0dc9ea0 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii changed the title [WIP] Add the KubeOne API refactor proposal Add the KubeOne Cluster API proposal Apr 11, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2019
@kron4eg
Copy link
Member

kron4eg commented Apr 11, 2019

/test pull-kubeone-e2e-aws-conformance-1.13.5

@xmudrii
Copy link
Member Author

xmudrii commented Apr 11, 2019

/retest

kron4eg
kron4eg approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aab79930c91676e63a9e26a79ae1ef89b6640d2a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2019
@kron4eg
Copy link
Member

kron4eg commented Apr 11, 2019

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-conformance-1.14.1
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-aws-conformance-1.13.5, pull-kubeone-e2e-digitalocean-conformance-1.13.5, pull-kubeone-e2e-digitalocean-conformance-1.14.1, pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-conformance-1.14.1
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 1037f91 into master Apr 11, 2019
@xmudrii xmudrii deleted the api-proposal branch April 12, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot