Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the KubeOneCluster API proposal #358

Merged
merged 1 commit into from
Apr 19, 2019
Merged

Update the KubeOneCluster API proposal #358

merged 1 commit into from
Apr 19, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 19, 2019

What this PR does / why we need it:

This PR updates the KubeOneCluster API proposal to match what's actually implemented in the #353.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #259

Release note:

NONE

/assign @kron4eg
/cc @kron4eg

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 19, 2019
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2019
@xmudrii
Update the KubeOneCluster API proposal
ad6b9cb 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Apr 19, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Apr 19, 2019

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-conformance-1.13.5

In response to this:

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-conformance-1.13.5 ad6b9cb link /test pull-kubeone-e2e-digitalocean-conformance-1.13.5
pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1 ad6b9cb link /test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Apr 19, 2019

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kron4eg
kron4eg approved these changes Apr 19, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 501ee7194d0369a6cc8c7b42b5b7ef1dfc33f9a3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@kubermatic-bot kubermatic-bot merged commit f64259f into master Apr 19, 2019
@kubermatic-bot kubermatic-bot deleted the update-api-proposal branch April 19, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg