Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 'config migrate' command #408

Merged
merged 16 commits into from
May 5, 2019
Merged

Implement 'config migrate' command #408

merged 16 commits into from
May 5, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 4, 2019

What this PR does / why we need it:

Implement the config migrate command that takes a path to the old configuration manifest and prints manifest converted to the KubeOneCluster API.

In a follow-up I'll document changes made to the API and how to use the migration command.

Before merging the PR I'd like to write some unit tests based on .golden files.

Big thanks to @xrstf for helping us with this!

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #259
the issue will be closed once the document explaining how to migrate to the new API is added

Release note:

Implement 'config migrate' command for migration to the KubeOneCluster API

xmudrii and others added 7 commits May 4, 2019 20:37
@xmudrii
migratecmd
1ac28b2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xrstf @xmudrii
switch to yamled for migration
c00f900 
Signed-off-by: Christoph Mewes <christoph@loodse.com>
@xrstf @xmudrii
use the right YAML library for ensure the matchup with our types
52cbc33 
Signed-off-by: Christoph Mewes <christoph@loodse.com>
@xrstf @xmudrii
apiEndpoints is now a list
3b3e79d 
Signed-off-by: Christoph Mewes <christoph@loodse.com>
@xmudrii
Turn apiEndpoints into apiEndpoint
a141f3e 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy pkg/yamled to pkg/util/yamled
eb6d70b 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Implement 'config migrate' command
ed08113 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2019
@xmudrii
Add license headers to .go files in pkg/util/yamled
8fce2b9 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Run dep ensure
22d5ee4 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Fix lint errors
ee741cf 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Migrate v0.5.0 Features API to new API
19ac0f2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add validation after migration
ab3489e 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add migrate unit tests based on .golden files
68f2716 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Run dep ensure
212196d 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

@kron4eg ready for review :shipit:

@xmudrii xmudrii requested a review from kron4eg May 5, 2019 12:56
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/assign @kron4eg

@xmudrii xmudrii changed the title [WIP] Implement 'config migrate' command Implement 'config migrate' command May 5, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2019
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

I can't reproduce this locally
/retest

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

DNS flake
/retest

@kron4eg
Copy link
Member

kron4eg commented May 5, 2019

/retest

kron4eg
kron4eg requested changes May 5, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Only small thing to fix is -update flag, otherwise LGTM

pkg/config/migrate_test.go Outdated Show resolved Hide resolved
@xmudrii
Add -update flag to update .golden flags
c56c477 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Fix lint error
2425be1 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kron4eg
Copy link
Member

kron4eg commented May 5, 2019

/retest

kron4eg
kron4eg approved these changes May 5, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3c56e432155a9b156243e64e2108c63d07ab0ff

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2019
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/retest

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 2425be1 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member

kron4eg commented May 5, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 7361318 into master May 5, 2019
@kubermatic-bot kubermatic-bot deleted the api-migration/command branch May 5, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kron4eg @kubermatic-bot @xrstf