Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to migrate to the new API and changes made in the API #410

Merged
merged 1 commit into from
May 5, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 5, 2019

What this PR does / why we need it:

This PR adds a document showing how to migrate to the new API and what changes are made in the new API (based on the description of #390).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #259
🎉

Release note:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg May 5, 2019 20:47
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2019
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approv

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dcee1bd84e60c92b6f1d56b22bbda549b0159be5

@kron4eg
Copy link
Member

kron4eg commented May 5, 2019

/approve

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2019
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2019
@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

@kron4eg You'll need to /lgtm again 😅

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-conformance-1.13.5, pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-conformance-1.13.5
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/override pull-kubeone-e2e-digitalocean-conformance-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-conformance-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-conformance-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member

kron4eg commented May 5, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3e33463b9f7fddc7115606943ed6e26c7ea98817

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-conformance-1.13.5, pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-conformance-1.13.5 364eb44 link /test pull-kubeone-e2e-digitalocean-conformance-1.13.5
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 364eb44 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1
pull-kubeone-e2e-digitalocean-conformance-1.14.1 364eb44 link /test pull-kubeone-e2e-digitalocean-conformance-1.14.1
pull-kubeone-e2e-aws-conformance-1.13.5 364eb44 link /test pull-kubeone-e2e-aws-conformance-1.13.5
pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1 364eb44 link /test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1
pull-kubeone-e2e-aws-conformance-1.14.1 364eb44 link /test pull-kubeone-e2e-aws-conformance-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented May 5, 2019

/override pull-kubeone-e2e-aws-conformance-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-conformance-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-conformance-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 4a255c9 into master May 5, 2019
@kubermatic-bot kubermatic-bot deleted the api-migration/docs branch May 5, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeOne API and Configuration Versioning
3 participants