Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the 'config print' command #412

Merged
merged 2 commits into from
May 6, 2019
Merged

Implement the 'config print' command #412

merged 2 commits into from
May 6, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 6, 2019

What this PR does / why we need it:

This PR implements the config print command which prints an example configuration manifest. The command takes flags used to customize the configuration manifest.

List of available flags:

Flags:
  -n, --cluster-name string          cluster name
      --deploy-machine-controller    deploy kubermatic machine-controller (default true)
      --enable-dynamic-audit-log     enable DynamicAuditLog
      --enable-metrics-server        enable metrics-server (default true)
      --enable-pod-security-policy   enable PodSecurityPolicy
  -h, --help                         help for print
  -k, --kubernetes-version string    Kubernetes version (default "1.14.1")
  -p, --provider string              cloud provider name (aws, digitalocean, gce, hetzner, packet, openstack, none) (default "aws")

Command description:

Print an example configuration manifest. Using the appropriate flags you can customize the configuration manifest.
For the full reference of the configuration manifest check the config.yaml.dist manifest
https://github.com/kubermatic/kubeone/blob/master/config.yaml.dist

Usage:
  kubeone config print [flags]

Examples:
kubeone config print

Example:

kubeone config print -n kubeone --enable-pod-security-policy --kubernetes-version 1.14.1
apiVersion: kubeone.io/v1alpha1
kind: KubeOneCluster
name: kubeone
versions:
  kubernetes: 1.14.1
cloudProvider:
  name: aws
features:
  podSecurityPolicy:
    enable: true

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #254

Release note:

Implement the 'config print` command for printing example configuration manifest

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg May 6, 2019 16:08
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 6, 2019
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 6, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ce3d3d0119a710d3c849ead6915b103c5d2b6b5

@kron4eg
Copy link
Member

kron4eg commented May 6, 2019

/retest

@kron4eg
Copy link
Member

kron4eg commented May 6, 2019

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-aws-conformance-1.13.5 c272b3f link /test pull-kubeone-e2e-aws-conformance-1.13.5
pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1 c272b3f link /test pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-aws-conformance-1.13.5, pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-aws-conformance-1.13.5
/override pull-kubeone-e2e-aws-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit ec0e95f into master May 6, 2019
@kubermatic-bot kubermatic-bot deleted the config-print branch May 6, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a command for printing an example configuration file
3 participants