Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsphere support #428

Merged
merged 8 commits into from
May 30, 2019
Merged

vsphere support #428

merged 8 commits into from
May 30, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 9, 2019 •
edited
Loading

Fixes #277

vSphere support

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2019
@kron4eg
Copy link
Member Author

kron4eg commented May 9, 2019

My local vars was:

cluster_name = "artiom42"
datastore_name = "exsi-nas"
network_name = "VM Network"
template_name = "machine-controller-e2e-ubuntu"

@kron4eg kron4eg mentioned this pull request May 9, 2019
Closed
@kdomanski
Copy link
Contributor

You cannot really do OS customization through vsphere API for the templates we use. We don't even do that in machine-controller, we use metadata or an ISO depending on the OS.

After removing the customize { ... } section it is working fine for me. @kron4eg

See also:

@kron4eg
Copy link
Member Author

kron4eg commented May 27, 2019

OH... That'd explain it. I'll try another time, thanks!

@kron4eg
vsphere terraform
85b5def 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
fixes in vsphere terraform config
a4482bd 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
handle vsphere flags
49a7ed0 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Provide vmNetName in vsphere
ae20e4f 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2019
@kron4eg kron4eg changed the title WIP vsphere terraform vsphere support May 30, 2019
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels May 30, 2019
@xmudrii
Copy link
Member

xmudrii commented May 30, 2019

/retest

@kron4eg
Handle vsphere server sheme prefix
8443289 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
vSphere quick start guide
3276e88 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Handle vSphere vmNetName
c22fb33 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
xmudrii
xmudrii reviewed May 30, 2019
View reviewed changes
docs/quickstart-vsphere.md Outdated

To follow this quick start, you'll need:

* `kubeone` v0.7.0 or newer installed, which can be done by following the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, you need master or v0.8.0, because v0.7.0 doesn't support vSphere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 done

@kron4eg
Micro tweaks in quickstart-vsphere.md
2fc3c58 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xmudrii
Copy link
Member

xmudrii commented May 30, 2019

/lgtm
/approve

🎉 💯

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d093bcf71ea368df09d0c2e8bfb80bbd9a9d0449

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2019
@kubermatic-bot kubermatic-bot merged commit 2f90f6f into master May 30, 2019
@kubermatic-bot kubermatic-bot deleted the vsphere-terraform branch May 30, 2019 11:41
@toschneck
Copy link
Member

Woohooo great job guys! @thetechnick is now ready for your setup 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support VMware vSphere
5 participants
@kron4eg @kdomanski @xmudrii @kubermatic-bot @toschneck