Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add weave-net as an alternative CNI plugin #432

Merged
merged 6 commits into from
May 14, 2019
Merged

Add weave-net as an alternative CNI plugin #432

merged 6 commits into from
May 14, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 11, 2019

What this PR does / why we need it:
Some environments demand encrypted network, and currently only weave can provide it.

Fixes #256

Add weave-net as an alternative CNI plugin

@kron4eg kron4eg requested a review from xmudrii May 11, 2019 22:25
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 11, 2019
@kron4eg kron4eg changed the title Add weave-net as an alternative CNI plugin WIP: Add weave-net as an alternative CNI plugin May 11, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2019
@kron4eg
add weave-net as a CNI plugin
185cfaa 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Some more kubelet flags
02f88aa 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg changed the title WIP: Add weave-net as an alternative CNI plugin Add weave-net as an alternative CNI plugin May 12, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 12, 2019
@kron4eg
Pass KUBE_PEERS to weave to bootstrap networking
0a1e645 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented May 12, 2019

/retest

xmudrii
xmudrii reviewed May 13, 2019
View reviewed changes
config.yaml.dist Outdated Show resolved Hide resolved
config.yaml.dist Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeone/validation/validation.go Show resolved Hide resolved
pkg/templates/kubeadm/v1beta1/kubeadm.go Show resolved Hide resolved
pkg/templates/kubeadm/v1beta1/kubeadm.go Show resolved Hide resolved
@kron4eg
Move CNI validation to dedicated function
d764a88 
plus some docs tweaks

Signed-off-by: Artiom Diomin <kron82@gmail.com>
xmudrii
xmudrii reviewed May 13, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some more comments.

config.yaml.dist Outdated Show resolved Hide resolved
config.yaml.dist Outdated Show resolved Hide resolved
pkg/apis/kubeone/types.go Show resolved Hide resolved
pkg/apis/kubeone/types.go Show resolved Hide resolved
pkg/apis/kubeone/v1alpha1/types.go Show resolved Hide resolved
@kron4eg
config.yaml.dist -> kubeone config print --full
f2e7d52 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2019
@kron4eg
Update kubeone API types
b03b3b8 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented May 13, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented May 14, 2019

@xmudrii PR is ready

xmudrii
xmudrii approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments seem fixed.
/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 335dd406591289714f2cd3227594dcb6210cfd6c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2019
@kubermatic-bot kubermatic-bot merged commit 2dca8ad into master May 14, 2019
@kubermatic-bot kubermatic-bot deleted the 256-add-weave-net branch May 14, 2019 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reconsider using Canal CNI or document the reasoning behind it
3 participants
@kron4eg @kubermatic-bot @xmudrii