Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert terraform example files to be v0.12 compatible #466

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Convert terraform example files to be v0.12 compatible #466

merged 1 commit into from
Jun 17, 2019

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented May 28, 2019 •
edited
Loading

Have done that by running terraform 0.12upgrade for each example

What this PR does / why we need it:
Terraform upstream version is 0.12 and we should support it. v0.12 introduces language breaking changes that make 0.12 and 0.11 incompatible with each other.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #463

Special notes for your reviewer:
None

Documentation:
Rewrote Docs to match version, added terraform version to compatibility matrix

Release note:
Since only examples are changes, does this require "action required"?

Terraform examples are now written for version 0.12, but will not work with version 0.11 anymore.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 28, 2019
@xmudrii
Copy link
Member

xmudrii commented May 28, 2019

/assign @kron4eg
/cc @kron4eg

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels May 28, 2019
xmudrii
xmudrii reviewed May 29, 2019
View reviewed changes
docs/quickstart-aws.md Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 29, 2019
@kron4eg
Copy link
Member

kron4eg commented May 29, 2019

terraform output json has changed, and requires changes in https://github.com/kubermatic/kubeone/blob/master/pkg/terraform/config.go#L41-L57

@kron4eg
Copy link
Member

kron4eg commented May 30, 2019

there is new target to convert, vsphere just got merged :) please rebase and cover it too.

@kron4eg
Copy link
Member

kron4eg commented May 30, 2019

I figured, since we going to need to stick to 0.12 version of terraform, we'd need to update compatibility matrix here and indicate which kubeone version is compatible with which terraform version.

@eqrx eqrx mentioned this pull request May 31, 2019
Closed
@kubermatic-bot kubermatic-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2019
@xmudrii xmudrii mentioned this pull request Jun 1, 2019
Closed
@kubermatic-bot kubermatic-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 5, 2019
@kron4eg
Copy link
Member

kron4eg commented Jun 6, 2019

/retest

@eqrx eqrx added this to the v0.9 milestone Jun 12, 2019
@kron4eg
Copy link
Member

kron4eg commented Jun 13, 2019

/retest

@eqrx eqrx requested a review from xmudrii June 14, 2019 09:28
@eqrx
Copy link
Contributor Author

eqrx commented Jun 14, 2019

I needed to rebase again to match master. If tests fail, rerun them please. They went through the last attempts on second execution :)

kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-azure.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-gce.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-aws.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-hetzner.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-packet.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
docs/quickstart-vsphere.md Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
hack/run_ci_e2e_test.sh Outdated Show resolved Hide resolved
kron4eg
kron4eg reviewed Jun 17, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some small comments, looks great!

Use Terraform version 0.12.0
1b75dbe 
Converted terraform example files with some help of `terraform 0.12upgrade`,
extended documentation and updated config parser.

Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
kron4eg
kron4eg approved these changes Jun 17, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b1d44f01bc775fa8e46fd75f67d20f8536412492

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2019
@kubermatic-bot kubermatic-bot merged commit fc776e9 into kubermatic:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Error: Incorrect attribute value type deploying on AWS with Terraform
4 participants
@eqrx @xmudrii @kron4eg @kubermatic-bot