Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair ability to read terraform output from stdin #479

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Repair ability to read terraform output from stdin #479

merged 1 commit into from
Jun 6, 2019

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Jun 6, 2019 •
edited
Loading

What this PR does / why we need it:
Fixes #478

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #478

Special notes for your reviewer:
None

Documentation:
None

Release note:

None

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2019
Repair ability to read terraform output from stdin
ffcd6bc 
Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
@eqrx eqrx force-pushed the terraformfromstdin branch from 46e6de1 to ffcd6bc Compare June 6, 2019 15:21
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jun 6, 2019
@eqrx eqrx requested a review from xmudrii June 6, 2019 15:23
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 6, 2019
kron4eg
kron4eg approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9ffe50a7973a8d993d88d5ceb727efd07e9426da

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2019
@eqrx
Copy link
Contributor Author

eqrx commented Jun 6, 2019

Tests seem to fail because of test environment failures.

@xmudrii
Copy link
Member

xmudrii commented Jun 6, 2019

/retest

1 similar comment
@kron4eg
Copy link
Member

kron4eg commented Jun 6, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 5f8a9f9 into master Jun 6, 2019
@kubermatic-bot kubermatic-bot deleted the terraformfromstdin branch June 6, 2019 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help text allows reading terraform output via stdin but it doesn't work
4 participants
@eqrx @kubermatic-bot @xmudrii @kron4eg