Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests for Packet and GCE. Drop 1.13 tests and use 1.14.3 instead of 1.14.1 #489

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Add E2E tests for Packet and GCE. Drop 1.13 tests and use 1.14.3 instead of 1.14.1 #489

merged 3 commits into from
Jun 18, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 12, 2019 •
edited
Loading

What this PR does / why we need it:

This PR adds E2E tests for Packet and GCE.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #403
xref #388
xref #372

Release note:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg June 12, 2019 09:14
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jun 12, 2019

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Jun 12, 2019

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jun 12, 2019

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Jun 12, 2019

/retest

@xmudrii xmudrii changed the title Add E2E tests for Packet and GCE Add E2E tests for Packet and GCE. Drop 1.13 tests and use 1.14.3 instead of 1.14.1 Jun 12, 2019
kron4eg
kron4eg reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments and questions

hack/run_ci_e2e_test.sh Show resolved Hide resolved
test/e2e/conformance_test.go Show resolved Hide resolved
test/e2e/provisioner/gce.go Outdated Show resolved Hide resolved
@kubermatic-bot kubermatic-bot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Jun 12, 2019
kron4eg
kron4eg reviewed Jun 12, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, it will allow to drop dedicated GCE provisioner

test/e2e/provisioner/default.go Outdated Show resolved Hide resolved
test/e2e/provisioner/default.go Outdated Show resolved Hide resolved
@kubermatic-bot
Copy link
Contributor

@xmudrii: ¯\_(ツ)_/¯

In response to this:

The GCEProvisioner is removed in favor of the proposed approach.

/unshrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot removed the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Jun 18, 2019
@xmudrii
Add E2E tests for Packet and GCE
f317a8f 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Drop 1.13 and switch to 1.14
565a8f2 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii force-pushed the extend-e2e branch 2 times, most recently from 94b4324 to 0b3249a Compare June 18, 2019 07:04
@xmudrii
Remove GCEProvisioner
28c3bde 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kron4eg
kron4eg approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f050ce1e349c5f082a8f3b4a35d4de3a8419cb0e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jun 18, 2019

/test all

@xmudrii
Copy link
Member Author

xmudrii commented Jun 18, 2019

/test pull-kubeone-e2e-digitalocean-conformance-1.14.3
/test pull-kubeone-e2e-hetzner-conformance-1.14.3
/test pull-kubeone-e2e-gce-conformance-1.14.3
/test pull-kubeone-e2e-packet-conformance-1.14.3

@kubermatic-bot
Copy link
Contributor

@xmudrii: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-gce-conformance-1.14.3 28c3bde link /test pull-kubeone-e2e-gce-conformance-1.14.3
pull-kubeone-e2e-packet-conformance-1.14.3 28c3bde link /test pull-kubeone-e2e-packet-conformance-1.14.3

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Jun 18, 2019

Required tests are passing. In order to re-enable the tests, I'm going to merge this and fix problems in a follow up.

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 18, 2019
@kubermatic-bot kubermatic-bot merged commit ac12974 into master Jun 18, 2019
@kubermatic-bot kubermatic-bot deleted the extend-e2e branch June 18, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg