Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machinecontroller to 1.2.1 and use proxy for kubelets #496

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Update machinecontroller to 1.2.1 and use proxy for kubelets #496

merged 1 commit into from
Jun 14, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jun 14, 2019 

kubelets will have proxy support if it's specified in config

@kron4eg
Update machinecontroller to 1.2.1 and use proxy for kubelets as well
aebb199 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii June 14, 2019 15:04
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2019
xmudrii
xmudrii approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 038e2f27cb3a6b0381d44c330f71c3f22c1bf55f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Jun 14, 2019

/retest

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jun 14, 2019 •
edited
Loading

@kron4eg: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1 aebb199 link /test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kron4eg
Copy link
Member Author

kron4eg commented Jun 14, 2019

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

@kubermatic-bot
Copy link
Contributor

@kron4eg: Overrode contexts on behalf of kron4eg: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

In response to this:

/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit c4f510c into master Jun 14, 2019
@kubermatic-bot kubermatic-bot deleted the mc-121 branch June 14, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii