-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make reset a bit more robust #508
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny nit. It'd be nice to extend the message, so the user knows what happened if we don't have that already in place.
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
* Retry failed operations * Don't error out on not found some of the objects that can be deleted by controllers (avoid race-condition) * Log a message to try to use --destroy-workers=false flag Signed-off-by: Artiom Diomin <kron82@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: b203e434f60458481425e7f0fb41070a2f502534
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
* Update README.md * Make install steps version-agnostic * Recommend using officially released versions over running of the master branch * Mention that support for package managers is work in progress * Add support for Kubernetes 1.15 to the compatibility table * Minor updates and preparation for v0.9 Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Update the release process document Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Add changelog for release v0.9.0 Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Add #508 to the changelog Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Add #486 to the changelog Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Update CHANGELOG.md with recent changes Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Minor README improvements Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Revert NodeLocalDNSCache Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com> * Change v0.9 release date in changelog Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Fixes #474