Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use systemd cgroups driver on CoreOS and enable kubelet by default #541

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Use systemd cgroups driver on CoreOS and enable kubelet by default #541

merged 1 commit into from
Jul 3, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 3, 2019 •
edited
Loading

What this PR does / why we need it:

This PR configures Docker on CoreOS to use systemd as a cgroups manager and overlay2 as a storage driver. The installation script for CoreOS will now short-circuit if Docker and Kubelet are already present, like on Ubuntu and CentOS.

Lastly, Kubelet service is now enabled by default on Ubuntu and CentOS (it is already done on CoreOS). On Ubuntu it should have been like this by default, but not on CoreOS, causing kubeadm to complain.

Note that CoreOS still has 2 warnings that should be resolved, but those are not related to the IsDockerSystemdCheck warning.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #363

Does this PR introduce a user-facing change?:

Fix kubeadm warnings on CentOS and CoreOS

/assign @kron4eg

@xmudrii
Use systemd cgroups driver on CoreOS and enable kubelet by default
9df09a6 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg July 3, 2019 12:56
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Jul 3, 2019

/cherrypick release/v0.9

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v0.9 in a new PR and assign it to you.

In response to this:

/cherrypick release/v0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kron4eg
kron4eg approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 368965a7f22ffc874913cfc635b13ff3b9ad20a3

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@kubermatic-bot kubermatic-bot merged commit 5fcb230 into master Jul 3, 2019
@kubermatic-bot kubermatic-bot deleted the fix-cgroups-all branch July 3, 2019 14:13
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 3, 2019
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #547

In response to this:

/cherrypick release/v0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WARNING IsDockerSystemdCheck
3 participants
@xmudrii @kubermatic-bot @kron4eg