Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubelet upgrade on Container Linux #556

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Fix kubelet upgrade on Container Linux #556

merged 2 commits into from
Jul 4, 2019

Conversation

ainmosni
Copy link
Contributor

@ainmosni ainmosni commented Jul 4, 2019

What this PR does / why we need it:

On Container Linux, kubelet locks itself, this patch stops kubelet
before downloading the new binaries and then starts it back up once
everything is ready.

* Fix issue where kubelet wouldn't properly upgrade on Container Linux

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 4, 2019
@kubermatic-bot
Copy link
Contributor

Hi @ainmosni. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2019
@ainmosni ainmosni changed the title Fix kubelet upgrade on Container Linux WIP: Fix kubelet upgrade on Container Linux Jul 4, 2019
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2019
@ainmosni
Properly stop and restart kubelet
ea5dfbc 
On Container Linux, kubelet locks itself, this patch stops kubelet
before downloading the new binaries and then starts it back up once
everything is ready.

Signed-off-by: Daniël Franke <daniel@ams-sec.org>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 4, 2019
@ainmosni ainmosni changed the title WIP: Fix kubelet upgrade on Container Linux Fix kubelet upgrade on Container Linux Jul 4, 2019
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2019
@kron4eg
Copy link
Member

kron4eg commented Jul 4, 2019

/cherrypick release/v0.9

@kubermatic-bot
Copy link
Contributor

@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v0.9 in a new PR and assign it to you.

In response to this:

/cherrypick release/v0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 4, 2019
@ainmosni
Download the binaries before stopping kubelet.
44f8041 
Signed-off-by: Daniël Franke <daniel@ams-sec.org>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 4, 2019
kron4eg
kron4eg approved these changes Jul 4, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c7dbde6fa2da9108bed2eabf00a9889d0c5759a6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2019
@kron4eg
Copy link
Member

kron4eg commented Jul 4, 2019

/hold

@xmudrii please unhold once done

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2019
@xmudrii
Copy link
Member

xmudrii commented Jul 4, 2019

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2019
@kubermatic-bot kubermatic-bot merged commit 570bba6 into kubermatic:master Jul 4, 2019
@kubermatic-bot kubermatic-bot mentioned this pull request Jul 4, 2019
Merged
@kubermatic-bot
Copy link
Contributor

@kron4eg: new pull request created: #559

In response to this:

/cherrypick release/v0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ainmosni @kubermatic-bot @kron4eg @xmudrii