Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taint control plane nodes by default #564

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Taint control plane nodes by default #564

merged 1 commit into from
Jul 8, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 6, 2019

What this PR does / why we need it:

  • always taint control plane nodes
  • timeout for bootstrap tokens
Taint control plane nodes by default

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2019
@kron4eg
Taint control plane nodes by default
7676785 
plus timeout on bootstrap tokens

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg requested a review from xmudrii July 6, 2019 10:06
xmudrii
xmudrii approved these changes Jul 8, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dde5ee2fecbcb4aa4756c5a1eb45ce989156ed4c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@kubermatic-bot kubermatic-bot merged commit 3b7cee7 into master Jul 8, 2019
@kubermatic-bot kubermatic-bot deleted the cp_taint branch July 8, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii