Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install subcommand not running without terraform output #574

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Jul 12, 2019

What this PR does / why we need it:
Fix install subcommand not running without terraform output

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
None

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2019
Signed-off-by: Alexander Sowitzki <alexander@loodse.com>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 12, 2019
@eqrx eqrx added this to the v0.10 milestone Jul 12, 2019
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f2d50622a53215723f1e9de43b2583777adb6d0

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2019
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eqrx
Copy link
Contributor Author

eqrx commented Jul 12, 2019

/retest

@eqrx
Copy link
Contributor Author

eqrx commented Jul 12, 2019

/run-faster

@kubermatic-bot kubermatic-bot merged commit af6c026 into master Jul 12, 2019
@kubermatic-bot kubermatic-bot deleted the fix branch July 12, 2019 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants