Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machine-controller to v1.5.2 #624

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Update machine-controller to v1.5.2 #624

merged 2 commits into from
Aug 20, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 20, 2019

What this PR does / why we need it:

This PR updates machine-controller to v1.5.2.

Does this PR introduce a user-facing change?:

Update machine-controller to v1.5.2

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg August 20, 2019 08:28
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 20, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Aug 20, 2019

/hold
until there's no changelog for this machine-controller release to ensure we don't need to change anything else

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
kron4eg
kron4eg approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1154b898d62d22a2d796356bb0b3ccb43906dce6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2019
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Aug 20, 2019

kubermatic/machine-controller#613 has removed the TemplateNetName field for vSphere workers spec, so I updated the PR to remove it from our spec too.

I don't think there are other breaking changes beside that one
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@kron4eg
Copy link
Member

kron4eg commented Aug 20, 2019

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a6d7841fc571127945747e4e5c6ce247ef7ccb31

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 20, 2019

This should be a flake
/retest

@kubermatic-bot kubermatic-bot merged commit e5792c4 into master Aug 20, 2019
@kubermatic-bot kubermatic-bot deleted the mc-1.5.2 branch August 20, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kubermatic-bot @kron4eg @kubermatic-triage-bot