Fix DestroyWorkers not retrying operations #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
LGTM label has been added. Git tree hash: 3426aad351eafddd4ae28c7f3636f46e4ac8d889
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When an error is returned in the function of
wait.ExponentialBackoff, it doesn't retry the operation again, but instead just fails. This PR is supposed to fix this by remembering the last error and parsing it outside of thewait.ExponentialBackofffunction.This could be helpful when KubeOne is waiting for all machines to be deleted. Recently, the AWS E2E tests were failing because it takes more time for worker machines to be deleted and as we haven't repeated the operation, it just failed after the first few minutes. This PR should eventually improve the stability of our tests.
Does this PR introduce a user-facing change?:
/assign @kron4eg