Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass proxy environment to machine-controller. #657

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Pass proxy environment to machine-controller. #657

merged 1 commit into from
Sep 16, 2019

Conversation

thz
Copy link
Contributor

@thz thz commented Sep 16, 2019

  • machine-controller and its webhook get HTTPS_PROXY and NO_PROXY

Fixes #656

**Special notes for your review

machine-controller can now work in proxy environments.

@thz
Pass proxy environment to machine-controller.
a10c191 
* machine-controller and its webhook get HTTPS_PROXY and NO_PROXY
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 16, 2019
@thz
Copy link
Contributor Author

thz commented Sep 16, 2019

/retest

kron4eg
kron4eg approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2771ec5e7128de33710f241c7fbd9a13c9dc812d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2019
@kubermatic-bot kubermatic-bot merged commit 2856929 into master Sep 16, 2019
@kubermatic-bot kubermatic-bot deleted the thz-proxy-env-for-mc branch September 16, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

machine-controller lacks proxy environment
3 participants
@thz @kubermatic-bot @kron4eg