Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields to workers Terraform integration #686

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Add missing fields to workers Terraform integration #686

merged 1 commit into from
Sep 24, 2019

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 24, 2019

What this PR does / why we need it:

  • Add ability to use spot instances for AWS worker nodes
  • Add ability to set TrustDevicePath for OpenStack worker nodes
  • Add ability to set BillingCycle and Tags for Packet worker nodes

For Hetzner we are missing Networks, used to define private networks. I'll add them as part of #596.

Does this PR introduce a user-facing change?:

Add ability to use spot instances for AWS worker nodes.
Add ability to set `TrustDevicePath` for OpenStack worker nodes.
Add ability to set `BillingCycle` and `Tags` for Packet worker nodes.

/assign @kron4eg

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2019
@xmudrii
Copy link
Member Author

xmudrii commented Sep 24, 2019

/retest

kron4eg
kron4eg approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67458b2784a616ecd50839c13588e6c4852b9595

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 673423c into master Sep 24, 2019
@kubermatic-bot kubermatic-bot added this to the v0.10 milestone Sep 24, 2019
@kubermatic-bot kubermatic-bot deleted the tf-workers-fields branch September 24, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg