Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubeone reset #727

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Fix kubeone reset #727

merged 1 commit into from
Oct 31, 2019

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 31, 2019 

Fix kubeone reset

@kron4eg kron4eg requested a review from xmudrii October 31, 2019 10:49
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 31, 2019
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2019
xmudrii
xmudrii approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b83aea84432197d6ae793f22d767888890ad7d29

@xmudrii
Copy link
Member

xmudrii commented Oct 31, 2019

/hold
I want to discuss something.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 31, 2019
@kron4eg
Fix kubeone reset
dc92bd3 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@kron4eg
Copy link
Member Author

kron4eg commented Oct 31, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Oct 31, 2019

/lgtm
/hold cancel

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 31, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fd409954a5df0ba5c4d173aa30811bb4442c91f2

@kron4eg
Copy link
Member Author

kron4eg commented Oct 31, 2019

/retest

3 similar comments
@kron4eg
Copy link
Member Author

kron4eg commented Oct 31, 2019

/retest

@kron4eg
Copy link
Member Author

kron4eg commented Oct 31, 2019

/retest

@xmudrii
Copy link
Member

xmudrii commented Oct 31, 2019

/retest

@kubermatic-bot kubermatic-bot merged commit 225cc72 into kubermatic:master Oct 31, 2019
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Oct 31, 2019
@kron4eg kron4eg deleted the reset-fix branch October 31, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii