Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 support #783

Merged
merged 1 commit into from
Feb 10, 2020
Merged

ARM64 support #783

merged 1 commit into from
Feb 10, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Feb 7, 2020

What this PR does / why we need it:
This is limited ARM64 support. Limited because there is no machine-controller for arm64.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #773

Special notes for your reviewer:

  • flannel image was replaced by our mirror at quay.io/kubermatic/coreos_flannel for multi-arch support
  • metrics-server image was replaces by our mirror at quay.io/kubermatic/metrics-server-mirror for multi-arch support

Mirrors are needed because upstream repositories doesn't have support for multi-arch manifests.

In follow-up PR I'll be adding new API field(s) to regulate master taints.

Does this PR introduce a user-facing change?:

ARM support

Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii February 7, 2020 16:07
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 7, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2020
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a comment regarding the image mirror. Besides that one, I want to see this documented somewhere, so users are aware and not surprised. This can be a sensitive topic and should be well-communicated with users.

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2fb2e14a21da8c944d73bd1295b6c3c0aa112b2

@kubermatic-bot kubermatic-bot merged commit 0ccdf7a into master Feb 10, 2020
@kubermatic-bot kubermatic-bot added this to the v0.11 milestone Feb 10, 2020
@kubermatic-bot kubermatic-bot deleted the arm-support branch February 10, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ARM Support
3 participants