-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM64 support #783
ARM64 support #783
Conversation
Signed-off-by: Artiom Diomin <artiom@loodse.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a comment regarding the image mirror. Besides that one, I want to see this documented somewhere, so users are aware and not surprised. This can be a sensitive topic and should be well-communicated with users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b2fb2e14a21da8c944d73bd1295b6c3c0aa112b2
|
What this PR does / why we need it:
This is limited ARM64 support. Limited because there is no machine-controller for arm64.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #773
Special notes for your reviewer:
Mirrors are needed because upstream repositories doesn't have support for multi-arch manifests.
In follow-up PR I'll be adding new API field(s) to regulate master taints.
Does this PR introduce a user-facing change?: