Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade machine-controller v1.11.2 #861

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Upgrade machine-controller v1.11.2 #861

merged 2 commits into from
Apr 10, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Apr 9, 2020

  • machine-controller v1.11.2
  • harmonize docker setup with machine-controller
  • harmonize docker config machine-controller

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #840

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

machine-controller v1.11.2

* harmonize docker setup with machine-controller
* harmonize docker config machine-controller

Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii April 9, 2020 12:39
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 9, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2020
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit/question, otherwise looks good to me.

@kron4eg
Copy link
Member Author

kron4eg commented Apr 10, 2020

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2020
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Copy link
Member Author

kron4eg commented Apr 10, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 10, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 30b0b18c95d1d82df5b1df7de8ee868c481a7597

@kubermatic-bot kubermatic-bot merged commit d42ddf4 into master Apr 10, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Apr 10, 2020
@kubermatic-bot kubermatic-bot deleted the mc-1.11.2 branch April 10, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update machine-controller to v1.11.2
3 participants