CNIProviderExternal is an external CNI plugin #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CNI plugin can be installed as Addon or manually
kubermatic-bot
added
release-note
xmudrii
reviewed
Apr 12, 2020
pkg/apis/kubeone/types.go
Outdated
| @@ -148,6 +148,11 @@ const ( | |||
| // * In case when encryption is enabled, strong secret will be autogenerated | |||
| // More info: https://www.weave.works/docs/net/latest/kubernetes/kube-addon/ | |||
| CNIProviderWeaveNet CNIProvider = "weave-net" | |||
|
|
|||
| // CNIProviderExternal is an external CNI plugin . | |||
There was a problem hiding this comment.
Suggested change
| // CNIProviderExternal is an external CNI plugin . | |
| // CNIProviderExternal is an external CNI plugin. |
Tiny nit: space is not needed here
pkg/cmd/config.go
Outdated
Comment on lines
428
to
429
| # * weave-net | ||
| # * external - The CNI plugin can be installed as Addon or manually |
There was a problem hiding this comment.
Suggested change
| # * weave-net | |
| # * external - The CNI plugin can be installed as Addon or manually | |
| # * weave-net | |
| # * external - The CNI plugin can be installed as Addon or manually |
Tiny nit: wrong indentation, please use spaces instead of tabs
kron4eg
approved these changes
Apr 12, 2020
|
LGTM label has been added. Git tree hash: b6dc28f6b98def4c3394d76aee25b94b0e667791
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: scheeles, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CNI plugin can be installed as Addon or manually