Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Packet CCM to v1.0.0 #884

Merged
merged 3 commits into from
Apr 27, 2020
Merged

Update Packet CCM to v1.0.0 #884

merged 3 commits into from
Apr 27, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 27, 2020 •
edited
Loading

What this PR does / why we need it:

  • Update Packet CCM to v1.0.0
  • Automatically create a secret with credentials and configuration needed for the CCM
  • Kubernetes 1.15.0+ is now required for Packet

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #750

Does this PR introduce a user-facing change?:

Update Packet CCM to v1.0.0
Automatically create a secret with credentials and configuration needed for the CCM
Kubernetes 1.15.0+ is now required for Packet

@xmudrii xmudrii requested a review from kron4eg April 27, 2020 11:42
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Apr 27, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Apr 27, 2020

/hold cancel
the PR is tested and the doc change is not required anymore

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6fccc9dfaed837a1f1a3004172778f7681816c04

@xmudrii
Copy link
Member Author

xmudrii commented Apr 27, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit a0d39bf into master Apr 27, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Apr 27, 2020
@kubermatic-bot kubermatic-bot deleted the packet-ccm-update branch April 27, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Nodes can not be initialized by packet CCM
3 participants
@xmudrii @kubermatic-bot @kron4eg