Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate cluster repair #888

Merged
merged 4 commits into from
May 3, 2020
Merged

Automate cluster repair #888

merged 4 commits into from
May 3, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 1, 2020 •
edited
Loading

What this PR does / why we need it:

  • Automate cluster repair
    • Detect and delete dead etcd members
  • Aid cluster recovery
    • Detect and delete dead corev1.Node objects

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #700
Fixes #530

Special notes for your reviewer:

* Automate cluster repair
* Aid cluster recovery

@kron4eg
Use tunneled http.RoundTripper instead of custom interfaces
e3148ef 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
Dedicated tunneled gRPC dialer NewGRPCDialer()
2255a44 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg
new package etcdutil
89ba928 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii May 1, 2020 23:18
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 1, 2020
@kron4eg
Automatically delete dead etcd members and Node objects
7cc0479 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@xmudrii
Copy link
Member

xmudrii commented May 1, 2020

/retest

xmudrii
xmudrii approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
💯 🎉

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e71319328544b21879bee50cc72f299e0de2c9b4

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 5bf9b90 into master May 3, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone May 3, 2020
@kubermatic-bot kubermatic-bot deleted the etcd-drop-member branch May 3, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.

Add ability to remove non-working etcd member from the cluster Add cluster repair functionality
3 participants
@kron4eg @xmudrii @kubermatic-bot