Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Flatcar/CoreOS kubelet unit #908

Merged
merged 1 commit into from
May 21, 2020
Merged

Fix Flatcar/CoreOS kubelet unit #908

merged 1 commit into from
May 21, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented May 21, 2020

What this PR does / why we need it:
Flatcar/CoreOS kubelet unit file still was incorrect, now fixed.

Fix Flatcar/CoreOS kubelet unit

@kron4eg
Fix Flatcar/CoreOS kubelet unit
2875877 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kron4eg kron4eg requested a review from xmudrii May 21, 2020 13:42
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2020
xmudrii
xmudrii approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: df67560f0c8ca1d9e11d9771bedf88abb72b74c1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 7227d4f into master May 21, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone May 21, 2020
@kubermatic-bot kubermatic-bot deleted the kubelet-flatcar branch May 21, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii