Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the proper package revision on CentOS and reintroduce the kubernetes-cni package #933

Merged
merged 3 commits into from
Jun 25, 2020
Merged

Use the proper package revision on CentOS and reintroduce the kubernetes-cni package #933

merged 3 commits into from
Jun 25, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 25, 2020

What this PR does / why we need it:

  • Use the proper/latest package revision on CentOS
  • Reintroduce the kubernetes-cni package

Does this PR introduce a user-facing change?:

Use the proper/latest package revision on CentOS
Reintroduce the kubernetes-cni package. The kubernetes-cni package is versioned by following the official/upstream recommendations, which means that 1.16.11+/1.17.7+/1.18.4+ use CNI v0.8.6, while older versions use v0.7.5.

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg June 25, 2020 10:40
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 25, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Jun 25, 2020

/hold
manual testing is currently in progress

@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2020
@kron4eg
Copy link
Member

kron4eg commented Jun 25, 2020

@xmudrii older versions are vulnerable, let's not use them

@xmudrii xmudrii force-pushed the k8s-patch1-support branch 2 times, most recently from 461eee1 to 258fd02 Compare June 25, 2020 12:31
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 25, 2020
@xmudrii xmudrii force-pushed the k8s-patch1-support branch from 258fd02 to edb8a43 Compare June 25, 2020 12:33
@xmudrii xmudrii force-pushed the k8s-patch1-support branch from edb8a43 to 24d84bf Compare June 25, 2020 12:41
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c8850694823c1afd10dda762aeecad3c18cab129

@xmudrii
Copy link
Member Author

xmudrii commented Jun 25, 2020

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Jun 25, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2020
@kubermatic-bot kubermatic-bot merged commit 0f64d4e into master Jun 25, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jun 25, 2020
@kubermatic-bot kubermatic-bot deleted the k8s-patch1-support branch June 25, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg