Update machine-controller to v1.15.1 and add the imagePlan field for Azure #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
xmudrii
commented
Jul 2, 2020
xmudrii
commented
Jul 2, 2020
| @@ -495,6 +496,11 @@ func setWorkersetFlag(w *kubeonev1beta1.DynamicWorkerConfig, name string, value | |||
| if s == nil { | |||
| return nil | |||
| } | |||
| case machinecontroller.AzureImagePlan: | |||
There was a problem hiding this comment.
Probably not needed because we use the pointer type, but I added it anyway because I can't test is it going to work without it.
xmudrii
changed the title
xmudrii
changed the title
kron4eg
approved these changes
Jul 2, 2020
|
LGTM label has been added. Git tree hash: c4154335394b9ee7390fbfca0fab59a17fdf7a11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update machine-controller to v1.15.1 and add the ImagePlan field for Azure.
Special notes for your reviewer:
The type of the
ImagePlanfield is different than for other fields. This time, the field type is a struct, and so far we only used primitive types. I don't have access to Azure, so I can't this is this going to work. I assume it should work this way, but I'm not sure.Does this PR introduce a user-facing change?: