Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recommended order of hosts removal #960

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Add recommended order of hosts removal #960

merged 1 commit into from
Jul 8, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 8, 2020

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #531

Does this PR introduce a user-facing change?:

NONE

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg July 8, 2020 11:08
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 8, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 8, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Jul 8, 2020

/hold
it doesn't work properly

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4bcb42f9de741343ff3cc024b10988a74d998d77

@xmudrii
Copy link
Member Author

xmudrii commented Jul 8, 2020

/retest
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@kubermatic-bot kubermatic-bot merged commit e0eeed1 into master Jul 8, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jul 8, 2020
@kubermatic-bot kubermatic-bot deleted the removal-order branch July 8, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg