Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention official Arch linux release in README #971

Merged

Conversation

shibumi
Copy link
Contributor

@shibumi shibumi commented Jul 10, 2020

What this PR does / why we need it:

Hi,
I've cleaned up the kubeone AUR package and moved kubeone to the official Arch Linux repositories. The AUR package will be removed. If necessary you can push a kubeone-git package to the AUR, but I think we stable release in the official repositories will work well.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

This PR just adds documentation in the README

Special notes for your reviewer:

The package can be found here: https://www.archlinux.org/packages/community/x86_64/kubeone/

and can be installed via pacman -S kubeone.
The PKGBUILD is here: https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/kubeone

I took the AUR PKGBUILD as template and cleaned it up + added zsh completions to it.

If you have any questions, feel free to ask :)

Does this PR introduce a user-facing change?:

No

@kubermatic-bot kubermatic-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 10, 2020
@kubermatic-bot
Copy link
Contributor

Hi @shibumi. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2020
@shibumi shibumi force-pushed the shibumi/kubeone-in-archlinux-repos branch from 5d5d9da to 5297455 Compare July 10, 2020 16:34
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 10, 2020
@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

@shibumi Thank you so much for the PR and the work to push KubeOne to the official Arch Linux repo!!

I have a question about updating the package. Once we release a new version of KubeOne, who is responsible for updating the package? Is that done by us (and if yes, are there any docs describing the process) or is that done by the Arch Linux community (and in that case, how often it is updated and is there anything we need to do to announce the new version)?

I left a tiny nit about markdown formatting, but besides that, everything looks great, including the PKGBUILD file. 💯 Other than that, if you want to do so, you can also update instructions in our documentation, located in the kubermatic/docs repo. If not, I'll take care of both markdown formatting and docs once this PR is merged. 🙂

Thank you once again!

@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

/release-note-none
/test all

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2020
README.md Outdated Show resolved Hide resolved
@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

/cc @eqrx

@kubermatic-bot kubermatic-bot requested a review from eqrx July 10, 2020 16:51
Signed-off-by: Christian Rebischke <chris@shibumi.dev>
@shibumi shibumi force-pushed the shibumi/kubeone-in-archlinux-repos branch from 5297455 to b7a5101 Compare July 10, 2020 16:57
@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

@shibumi Thank you for addressing the comment! The PR looks great to me! 💯 I'll put it on hold for @eqrx to review it if he wants and eventually for an answer to the question I left in a comment above.
/hold

/lgtm
/approve
/test all

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a5657d837b68ad2896bc245a3b7c63cc563baaf9

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shibumi, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@shibumi
Copy link
Contributor Author

shibumi commented Jul 10, 2020

@shibumi Thank you so much for the PR and the work to push KubeOne to the official Arch Linux repo!!

I have a question about updating the package. Once we release a new version of KubeOne, who is responsible for updating the package? Is that done by us (and if yes, are there any docs describing the process) or is that done by the Arch Linux community (and in that case, how often it is updated and is there anything we need to do to announce the new version)?

The update process is handled by me. I normally try to update whenever I get a 'new release' notification via Github (24 hours). Arch Linux is a rolling release distribution, so we don't keep old versions. We like our software fresh and as upstream as possible (we usually also apply no patches, except for security vulnerabilities or security enhancements like enabling PIE, RELRO, etc)

Btw do you have a slack channel at cncf.io, where I can idle? It makes sense to have a direct channel to the devs sometimes, if it's urgent :)

I left a tiny nit about markdown formatting, but besides that, everything looks great, including the PKGBUILD file. Other than that, if you want to do so, you can also update instructions in our documentation, located in the kubermatic/docs repo. If not, I'll take care of both markdown formatting and docs once this PR is merged.

Thank you once again!

I will have a look on your comment + on the kubeone documentation :)

EDIT: the comment for this PR should have been fixed already. I am using the code markdown syntax block now.

@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

@shibumi Sounds great, thank you for the detailed explanation!

Btw do you have a slack channel at cncf.io, where I can idle? It makes sense to have a direct channel to the devs sometimes, if it's urgent :)

We don't have a channel at cncf.io, but we have a channel on the official Kubernetes Slack where you can reach out to us (#kubeone, you can get an invite at slack.k8s.io if you're not part of that Slack already).

@shibumi
Copy link
Contributor Author

shibumi commented Jul 10, 2020

The corresponding change in the docs repo is done, as well: kubermatic/docs#362

@xmudrii
Copy link
Member

xmudrii commented Jul 10, 2020

The corresponding change in the docs repo is done, as well: kubermatic/docs#362

Thank you! I've gone ahead and approved the PR.

I'm also removing the hold from this PR. If there are any follow-up questions, we'll reach out to you over Slack. 🙂
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@kubermatic-bot kubermatic-bot merged commit 4d7b3f4 into kubermatic:master Jul 10, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants