Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CentOS8 AMIs #981

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Use CentOS8 AMIs #981

merged 1 commit into from
Jul 16, 2020

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Jul 15, 2020 •
edited
Loading

What this PR does / why we need it:
A way to utilize CentOS8 on AWS.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

CentOS8 on AWS

/hold
until kubermatic/machine-controller#793 is released and upgraded here

@kron4eg
use CentOS8 AMIs
cb3303e 
Signed-off-by: Artiom Diomin <artiom@loodse.com>
@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 15, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 15, 2020
@xmudrii
Copy link
Member

xmudrii commented Jul 15, 2020 •
edited
Loading

@kron4eg This looks good to me, but it's not going to work until there's no new MC release with CentOS 8 support.

@kron4eg
Copy link
Member Author

kron4eg commented Jul 15, 2020

@kron4eg This looks good to me, but it's not going to work until there's no new MC release with CentOS 8 support.

yeah, that's why I've put it on hold with comment

until kubermatic/machine-controller#793 is released and upgraded here

@xmudrii
Copy link
Member

xmudrii commented Jul 15, 2020

yeah, that's why I've put it on hold with comment

haven't seen it, but you're right

xmudrii
xmudrii approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8623b01eaa13b1044140a4e9d1f3c549bbbfe6a8

@kron4eg kron4eg mentioned this pull request Jul 16, 2020
Merged
@kron4eg
Copy link
Member Author

kron4eg commented Jul 16, 2020

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2020
@kubermatic-bot kubermatic-bot merged commit dbb21ce into master Jul 16, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jul 16, 2020
@kubermatic-bot kubermatic-bot deleted the centos8-amis branch July 16, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii