Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip creating weave-passwd secret if it already exists #986

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 16, 2020

What this PR does / why we need it:

Running kubeone install on already provisioned cluster (e.g. to repair it) with WeaveNet CNI causes the following error:

INFO[14:54:35 CEST] Applying weave-net CNI plugin…               
WARN[14:54:36 CEST] Task failed, error was: failed to create weave-net Secret: secrets "weave-passwd" already exists

The reason for this error is that we try to unconditionally create the secret, even if it exists. This PR changes the behavior, so the secret is created only if it doesn't exist.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #531

Does this PR introduce a user-facing change?:

Ensure weave-passwd secret is created on install only if it doesn't exist

/assign @kron4eg

@xmudrii xmudrii requested a review from kron4eg July 16, 2020 13:05
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 16, 2020
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2020
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a5bbe77054dd537f83b95d90ec42ee2afd363e7

@xmudrii
Copy link
Member Author

xmudrii commented Jul 16, 2020

/retest

1 similar comment
@xmudrii
Copy link
Member Author

xmudrii commented Jul 16, 2020

/retest

@kubermatic-bot kubermatic-bot merged commit 20097ef into master Jul 16, 2020
@kubermatic-bot kubermatic-bot added this to the v1.0 milestone Jul 16, 2020
@kubermatic-bot kubermatic-bot deleted the weave-secret-exists branch July 16, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants