Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update promtail to 2.5.0 #10082

Merged
merged 1 commit into from
Jun 14, 2022
Merged

update promtail to 2.5.0 #10082

merged 1 commit into from
Jun 14, 2022

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 14, 2022 •
edited
Loading

What does this PR do / Why do we need it:
After #9648 broke our promtail chart and #9693 brought it back to life, this PR now properly updates the chart after upstream has fixed its issues.

Note that a single "client" configuration has been deprecated in promtail since forever (grafana/loki#536), so this PR now moves to the new "clients" configuration, as does the upstream chart. This is a breaking change.

Does this PR introduce a user-facing change?:

ACTION REQUIRED: Update Promtail to v2.5.0; the `config.client` configuration has been replaced by `config.clients` instead. If you overwrote the Promtail client (=Loki), please adjust your `values.yaml` accordingly.

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🚀

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d487773549afd0404614c5fddd9ac75af8e439d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 9f502ec into kubermatic:master Jun 14, 2022
@xrstf xrstf deleted the promtail-25 branch June 14, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/app-management Denotes a PR or issue as being assigned to SIG App Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik