-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KubernetesClient DiagnosticSource dependency #1561
Conversation
System.Diagnostics.DiagnosticSource has been included into the framework reference, no need to reference for net8
@@ -7,7 +7,7 @@ | |||
</PropertyGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is net6 only?
we already moved to net8 lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the System.Diagnostics.DiagnosticSource
is included in the shared framework, so there's no need to reference this package for most cases.
While we're using the UpDownCounter
in the code
private static readonly UpDownCounter<int> ActiveRequests = |
The UpDownCounter
has been introduced since .NET 7
see the API: https://apisof.net/catalog/c7f52491f5c19b75d271677fe9123886
The shared framework for .NET 6 only has the 6.0.x reference which does not support this UpDownCounter
, so we had to add a reference explicitly.
For .NET 7 and later frameworks, we could use the framework reference directly, so no need to add the reference for System.Diagnostics.DiagnosticSource
when targeting net8.0
I think
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
=========================================
Coverage ? 61.50%
=========================================
Files ? 103
Lines ? 3068
Branches ? 639
=========================================
Hits ? 1887
Misses ? 1181
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tg123, WeihanLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
System.Diagnostics.DiagnosticSource
has been included in the framework reference, no need to reference for net8fixes #1553