Move Fractions library inside project #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
This looks fine, but please add a README.md which includes a pointer to the original location for the source as well as the reason for the vendoring. Also, please include the LICENSE.txt file from the original repo in that directory. Thanks! |
|
Thanks @brendanburns. Added the |
|
LGTM. Thanks. |
JonJam
pushed a commit
to JonJam/csharp
that referenced
this pull request
Sep 8, 2018
* Move Fractions library inside project * Add README and license
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #160.
All of the
Fractionscode is taken as-is on their master branch, with the only difference being instead of using generated error messages (i.e. theirResourcesclass), I just use the string error messages directly. These are located at:Link to Changed Line
Original Code Before Change
Link to Changed Line
Original Code Before Change
Link to Changed Line
Original Code Before Change
Link to Changed Line
Original Code Before Change
Those 4 lines (and the removed
importat the top of each file) are the only difference from the original code.